services/horizon: Remove the optimization that uses COPY for liquidity pool insertion #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y pool insertion and revert to the previous method
tamirms
approved these changes
Dec 4, 2023
sreuland
reviewed
Dec 4, 2023
services/horizon/internal/ingest/processors/liquidity_pools_change_processor.go
Show resolved
Hide resolved
sreuland
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Remove the optimization that uses COPY for liquidity pool insertion and revert to the previous method.
Why
Fixes #5134
To improve liquidity pool data insert performance, the COPY command was introduced to perform bulk insertions (#5110). This optimization assumed only newly created liquidity pools would be inserted using the COPY method, preventing conflicts with existing records. However, when the final trust-line for a liquidity pool is removed, the corresponding liquidity pool record is marked for later deletion. And if a new trust-line is added before the actual deletion, inserting the updated liquidity pool data using COPY fails due to the duplicate record.
The solution is to revert to the original upsert method for liquidity pool insertions which handles both new insertions and updates to existing records.
Known limitations
N/A